Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix incorrect unit in cpu usage dashboard (backport #908) #909

Merged
merged 1 commit into from
Dec 26, 2024

Conversation

mergify[bot]
Copy link

@mergify mergify bot commented Dec 25, 2024

Problem:

Prometheus VM Metrics are not accurate whatsoever where cpu usage metrics at a percentage level are exceeding 200000% within the Harvester UI VM metrics.

Solution:

fix incorrect cpu usage unit, upgrade path fix is here: harvester/harvester#7250

Related Issue:
harvester/harvester#7086

Test plan:

  • Prepare a harvester cluster with this patch
  • Enable rancher-monitoring addon
  • Prepare some VMs (e.g. 3 VM)
  • Goto Grafana UI and wait for a couple of minutes
  • Check the value of cpu usage should fall in range [0, 100] in both Harvester VM Dashboard and Harvester VM Info Detail dashboards (during vm startup, the cpu usage may slightly go over 100%, after a while it should dramatically drop to a low value, like 2%)

This is an automatic backport of pull request #908 done by [Mergify](https://mergify.com).

Signed-off-by: Cooper Tseng <[email protected]>
(cherry picked from commit 0c43ec2)
@bk201 bk201 requested review from bk201 and starbops December 26, 2024 03:49
@bk201 bk201 merged commit 2ea78d8 into v1.4 Dec 26, 2024
7 checks passed
@brandboat brandboat deleted the mergify/bp/v1.4/pr-908 branch January 3, 2025 07:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants